doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-04-29 17:33:15 +02:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #11000] Copy Debug class from doctrine/common #12752

New Issue
Open
opened 2026-01-22 16:15:04 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:15:04 +01:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/doctrine/orm/pull/11000

State: closed
Merged: Yes

This is an alternative to https://github.com/doctrine/orm/pull/10999/commits/4c8934f2539f5f700eb7a724f94af8d109057a66 (the other commit in the associated PR still stands).

This reduces our dependency to this shared library that now holds very little code we use.
The class has not been copied verbatim:

  • Unused parameters and methods have been removed.
  • The class is final and internal.
  • Coding standards have been enforced, including enabling strict_types, which lead to casting a variable to string before feeding it to explode().
  • A bug found by static analysis has been addressed, where an INI setting obtained with ini_get() was compared with true, which is never returned by that function.

A follow-up of this PR could be to leverage Symfony's VarDumper component when available.

**Original Pull Request:** https://github.com/doctrine/orm/pull/11000 **State:** closed **Merged:** Yes --- This is an alternative to https://github.com/doctrine/orm/pull/10999/commits/4c8934f2539f5f700eb7a724f94af8d109057a66 (the other commit in the associated PR still stands). This reduces our dependency to this shared library that now holds very little code we use. The class has not been copied verbatim: - Unused parameters and methods have been removed. - The class is final and internal. - Coding standards have been enforced, including enabling `strict_types`, which lead to casting a variable to string before feeding it to `explode()`. - A bug found by static analysis has been addressed, where an INI setting obtained with `ini_get()` was compared with true, which is never returned by that function. A follow-up of this PR could be to leverage Symfony's VarDumper component when available.
admin added the pull-request label 2026-01-22 16:15:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#12752
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?