doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #10981] Take ReflectionType::allowsNull into account #12740

New Issue
Closed
opened 2026-01-22 16:15:01 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:15:01 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/10981

State: closed
Merged: No

This reintroduces the behavior removed in #8732 due to #8723 for 3.0

When you have a column with a typed property, then the null status of the property determines if the column's nullable mapping.

This is only done for fields and not for associations, because often association join columns need to be nullable to be updated later after the insert due to extra update and ordering reasons.

For 2.x, we will make this an opt-in behavior in the DefaultTypedFieldMapper and emit a deprecation if user is not opted-in.

Follow Up:

  • This allows clean up nullable check in computeInsertExecutionOrder and other places mentioned there in a comment.
**Original Pull Request:** https://github.com/doctrine/orm/pull/10981 **State:** closed **Merged:** No --- This reintroduces the behavior removed in #8732 due to #8723 for 3.0 When you have a column with a typed property, then the null status of the property determines if the column's `nullable` mapping. This is only done for fields and not for associations, because often association join columns need to be nullable to be updated later after the insert due to extra update and ordering reasons. For 2.x, we will make this an opt-in behavior in the `DefaultTypedFieldMapper` and emit a deprecation if user is not opted-in. Follow Up: * This allows clean up nullable check in `computeInsertExecutionOrder` and other places mentioned there in a comment.
admin added the pull-request label 2026-01-22 16:15:01 +01:00
admin closed this issue 2026-01-22 16:15:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#12740
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?