doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #10498] Use recognized array key #12411

New Issue
Closed
opened 2026-01-22 16:13:57 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:13:57 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/10498

State: closed
Merged: Yes

joinColumn has no meaning for the static PHP driver. That's because it performs no translation, unlike other drivers: we're using the ClassMetadata API directly.

Before this change, changing the value of the "name" key did not break the test suite. After this change, it does.

Found while working on https://github.com/doctrine/orm/pull/10405

**Original Pull Request:** https://github.com/doctrine/orm/pull/10498 **State:** closed **Merged:** Yes --- `joinColumn` has no meaning for the static PHP driver. That's because it performs no translation, unlike other drivers: we're using the ClassMetadata API directly. Before this change, changing the value of the "name" key did not break the test suite. After this change, it does. Found while working on https://github.com/doctrine/orm/pull/10405
admin added the pull-request label 2026-01-22 16:13:57 +01:00
admin closed this issue 2026-01-22 16:13:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#12411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?