doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #10433] Make sure tests from #7837 are actually run #12355

New Issue
Open
opened 2026-01-22 16:13:47 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:13:47 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/10433

State: closed
Merged: Yes

I noticed that when I remove this line

98e557b68e/lib/Doctrine/ORM/Tools/Pagination/Paginator.php (L169)

added in #7837 the corresponding tests still pass.

This is because the relevant branch in \Doctrine\ORM\Tools\Pagination\Paginator::getIterator() is not reached. A new necessary condition was added briefly afterwards in #7863, and that caused the tests to miss the relevant section.

With the change suggested here, removing the line will make the specific test fail again.

**Original Pull Request:** https://github.com/doctrine/orm/pull/10433 **State:** closed **Merged:** Yes --- I noticed that when I remove this line https://github.com/Ocramius/doctrine2/blob/98e557b68eeecd7f266f1e4628007aed2714026c/lib/Doctrine/ORM/Tools/Pagination/Paginator.php#L169 added in #7837 the corresponding tests still pass. This is because the relevant branch in `\Doctrine\ORM\Tools\Pagination\Paginator::getIterator()` is not reached. A new necessary condition was added briefly afterwards in #7863, and that caused the tests to miss the relevant section. With the change suggested here, removing the line will make the specific test fail again.
admin added the pull-request label 2026-01-22 16:13:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#12355
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?