doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #10368] Docs: Removing type: 'integer' from mappings #12305

New Issue
Open
opened 2026-01-22 16:13:39 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:13:39 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/10368

State: closed
Merged: Yes

Yet another micro-PR ;-) - as requested at https://github.com/doctrine/orm/pull/10364#issuecomment-1370155521

I also changed $currentPrice from float to int, since IMO it's better to store prices as int (=cents).

Question: Is there a reason why most typehints are int|null, instead of ?int? Should I change them?

**Original Pull Request:** https://github.com/doctrine/orm/pull/10368 **State:** closed **Merged:** Yes --- Yet another micro-PR ;-) - as requested at https://github.com/doctrine/orm/pull/10364#issuecomment-1370155521 I also changed `$currentPrice` from `float` to `int`, since IMO it's better to store prices as `int` (=cents). Question: Is there a reason why most typehints are `int|null`, instead of `?int`? Should I change them?
admin added the pull-request label 2026-01-22 16:13:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#12305
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?