doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #10229] Widen parameter type #12195

New Issue
Closed
opened 2026-01-22 16:13:14 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:13:14 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/10229

State: closed
Merged: Yes

This exception is used in two places, one where $generatedMode is clearly a string, and another where typing it as a string will cause a type error, because $generatedMode is supposed to be an int there.

Supposed to be an int: 465c02fe68/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php (L1720-L1728)

Supposed to be a string: 465c02fe68/lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php (L680-L682)

@mehldau this was introduced in https://github.com/doctrine/orm/pull/9118, please review

**Original Pull Request:** https://github.com/doctrine/orm/pull/10229 **State:** closed **Merged:** Yes --- This exception is used in two places, one where $generatedMode is clearly a string, and another where typing it as a string will cause a type error, because $generatedMode is supposed to be an int there. Supposed to be an int: https://github.com/doctrine/orm/blob/465c02fe68d683efd32a314417940629c54374c4/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php#L1720-L1728 Supposed to be a string: https://github.com/doctrine/orm/blob/465c02fe68d683efd32a314417940629c54374c4/lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php#L680-L682 @mehldau this was introduced in https://github.com/doctrine/orm/pull/9118, please review
admin added the pull-request label 2026-01-22 16:13:14 +01:00
admin closed this issue 2026-01-22 16:13:15 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#12195
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?