doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #10008] Fail gracefully if EM could not be constructed in tests #12037

New Issue
Closed
opened 2026-01-22 16:12:43 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:12:43 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/10008

State: closed
Merged: Yes

Our functional test hooks into test failures. Here, the method isQueryLogAvailable() is called which assumes that the entity manager had been constructed by the setUp method. However, if constructing the EM fails (for whatever reason) or the test fails even earlier, we will run into a null pointer here and we won't see the actual test failure. This PR fixes that problem.

**Original Pull Request:** https://github.com/doctrine/orm/pull/10008 **State:** closed **Merged:** Yes --- Our functional test hooks into test failures. Here, the method `isQueryLogAvailable()` is called which assumes that the entity manager had been constructed by the setUp method. However, if constructing the EM fails (for whatever reason) or the test fails even earlier, we will run into a null pointer here and we won't see the actual test failure. This PR fixes that problem.
admin added the pull-request label 2026-01-22 16:12:43 +01:00
admin closed this issue 2026-01-22 16:12:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#12037
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?