doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #9966] fix: class normalisation test #12007

New Issue
Open
opened 2026-01-22 16:12:37 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:12:37 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/9966

State: closed
Merged: Yes

As per https://github.com/doctrine/persistence/pull/301

This test was not added to fix a bug, but to make sure that classes are not normalized at the time for "performance reasons" this check makes no sense now and in fact causes bugs without the normalization, this was solved in the linked PR and now causes this test to fail

I changed the test to check for the exact opposite as per when it was first introduced 705a477067/tests/Doctrine/Tests/ORM/Mapping/ClassMetadataFactoryTest.php (L62)

**Original Pull Request:** https://github.com/doctrine/orm/pull/9966 **State:** closed **Merged:** Yes --- As per https://github.com/doctrine/persistence/pull/301 This test was not added to fix a bug, but to make sure that classes are not normalized at the time for "[performance reasons](https://github.com/doctrine/orm/issues/1750#issuecomment-162355601)" this check makes no sense now and in fact causes bugs without the normalization, this was solved in the linked PR and now causes this test to fail I changed the test to check for the exact opposite as per when it was first introduced https://github.com/doctrine/orm/blame/705a477067e7a68c834ed65605d8d230677b5eaf/tests/Doctrine/Tests/ORM/Mapping/ClassMetadataFactoryTest.php#L62
admin added the pull-request label 2026-01-22 16:12:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#12007
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?