[PR #9911] Show Expr::countDistinct() and Expr::concat() use variable-length argument lists #11968

New Issue

admin · 2026-01-22T16:12:29+01:00

admin commented

2026-01-22 16:12:29 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/9911

State: closed
Merged: Yes

Was PR #9909... somehow I committed to the 2.12.x branch, and have made a mess of the rebase.

The functions Expr::countDistinct() and Expr::concat() both use func_get_args() to accept a variable number of arguments.

They should explicitly show this via the "..." operator, which has been supported since PHP 5.6.

**Original Pull Request:** https://github.com/doctrine/orm/pull/9911 **State:** closed **Merged:** Yes --- Was PR #9909... somehow I committed to the `2.12.x` branch, and have made a mess of the rebase. --- The functions `Expr::countDistinct()` and `Expr::concat()` both use `func_get_args()` to accept a variable number of arguments. They should explicitly show this via the "`...`" operator, which has been supported since PHP 5.6.

admin added the pull-request label 2026-01-22 16:12:29 +01:00

admin referenced this issue

2026-01-22 16:16:57 +01:00

[PR #11968] Merge 2.20.x up into 2.21.x #13372

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#11968