doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #9762] Do not call AbstractSchemaManager::getDatabasePlatform() #11864

New Issue
Closed
opened 2026-01-22 16:12:09 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:12:09 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/9762

State: closed
Merged: Yes

AbstractSchemaManager::getDatabasePlatform() was deprecated in https://github.com/doctrine/dbal/pull/5387.

The reason why the foreign keys are used conditionally is really unclear. The conditional logic was originally introduced in 556f8699ee as a replacement for try/catch. FWIW, all supported platforms support foreign keys, although the SQLite platform declares that it doesn't.

**Original Pull Request:** https://github.com/doctrine/orm/pull/9762 **State:** closed **Merged:** Yes --- `AbstractSchemaManager::getDatabasePlatform()` was deprecated in https://github.com/doctrine/dbal/pull/5387. The reason why the foreign keys are used conditionally is really unclear. The conditional logic was originally introduced in https://github.com/doctrine/orm/commit/556f8699ee5e622f0d2375b209cd2e59b3390b55 as a replacement for `try`/`catch`. FWIW, all supported platforms support foreign keys, although the SQLite platform declares that it doesn't.
admin added the pull-request label 2026-01-22 16:12:09 +01:00
admin closed this issue 2026-01-22 16:12:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#11864
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?