doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-04-25 07:28:04 +02:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #9519] Trigger the desired code path #11675

New Issue
Open
opened 2026-01-22 16:11:31 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:11:31 +01:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/doctrine/orm/pull/9519

State: closed
Merged: Yes

Since v2.7.0 the ORM avoids using extra queries via the paginator component when the maximum results parameter isn't set on the original query. With that change, this test was not executing the code path that it was expected to run.

This makes sure we trigger the forcing of custom DBAL types when hydrating the identifiers, making sure we don't introduce bugs.

More info:

**Original Pull Request:** https://github.com/doctrine/orm/pull/9519 **State:** closed **Merged:** Yes --- Since v2.7.0 the ORM avoids using extra queries via the paginator component when the maximum results parameter isn't set on the original query. With that change, this test was not executing the code path that it was expected to run. This makes sure we trigger the forcing of custom DBAL types when hydrating the identifiers, making sure we don't introduce bugs. More info: - Forcing DBAL type conversion: https://github.com/doctrine/orm/pull/7905 - Issue on optimisation: https://github.com/doctrine/orm/issues/7829 - PR on optimisation: https://github.com/doctrine/orm/pull/7863 - Minor BC-break docs: https://github.com/doctrine/orm/blob/2.12.x/UPGRADE.md#minor-bc-break-paginator-output-walkers-arent-be-called-anymore-on-sub-queries-for-queries-without-max-results
admin added the pull-request label 2026-01-22 16:11:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#11675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?