mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
DDC-92: Remove DoctrineException and introduce Doctrine\ORM\ORMException and Doctrine\DBAL\DBALException instead #116
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @doctrinebot on GitHub (Nov 1, 2009).
Jira issue originally created by user romanb:
DoctrineException in the Common package currently serves as a base exception for DBAL and ORM. This is not optimal and the __callStatic handling already showed some issues where the real exception was hidden (var_export issue).
Therefore it makes much more sense to introdude ORMException and DBALException as the base exception classes of the respective packages.
@doctrinebot commented on GitHub (Nov 1, 2009):
@doctrinebot commented on GitHub (Jan 23, 2010):
Comment created by @beberlei:
I refactored Doctrine\DBAL\DriverManager in this regard.
@doctrinebot commented on GitHub (Feb 19, 2010):
Comment created by @beberlei:
My work is done :-)
@doctrinebot commented on GitHub (Feb 24, 2010):
Comment created by shurakai:
Roman, this issue is marked as "in progress" but I'm not sure if you are currently working on this. If you're not, I would like to offer to remove DoctrineException from the ORM package. Just tell me if I should do this.
@doctrinebot commented on GitHub (Feb 24, 2010):
Comment created by romanb:
@Christian: That would be great. You would need to replace all occurences of DoctrineException with either ORMException or a more specific subclass, creating the static exception methods as needed.
At the end of the day we want DoctrineException removed from the repo.
@doctrinebot commented on GitHub (Mar 1, 2010):
Comment created by shurakai:
The attached file removes DoctrineException from all packages and introduces several new classes.
Additionally, all DoctrineException tests are removed.
@doctrinebot commented on GitHub (Mar 2, 2010):
Comment created by romanb:
Applied the patch to my local copy. Will commit it together with a bunch of other stuff in a few days. Thanks!
@doctrinebot commented on GitHub (Mar 5, 2010):
Comment created by romanb:
Should be fixed now. Committed the patch from Christian.
@doctrinebot commented on GitHub (Mar 5, 2010):
Issue was closed with resolution "Fixed"
@doctrinebot commented on GitHub (Dec 13, 2015):
Imported 1 attachments from Jira into https://gist.github.com/91d58fefe9f59b605134