[PR #9268] Fix WhereInWalker description to better describe the behaviour of this class #11478

New Issue

admin · 2026-01-22T16:10:54+01:00

admin commented

2026-01-22 16:10:54 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/9268

State: closed
Merged: Yes

I changed the verb "replace" with "append" to better describe the behavior of this class. As you can see in lines from 105 to 140 the $AST->whereClause is not replaced with the IN condition, but the IN condition is appended.
This is not a detail since the verb "replace" generates confusion and in Issue https://github.com/doctrine/orm/issues/9042 we thought that there was a bug in the code.

**Original Pull Request:** https://github.com/doctrine/orm/pull/9268 **State:** closed **Merged:** Yes --- I changed the verb "replace" with "append" to better describe the behavior of this class. As you can see in lines from 105 to 140 the `$AST->whereClause` is not replaced with the IN condition, but the IN condition is appended. This is not a detail since the verb "replace" generates confusion and in Issue https://github.com/doctrine/orm/issues/9042 we thought that there was a bug in the code.

admin added the pull-request label 2026-01-22 16:10:54 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#11478