[PR #8942] Remove remaining call to prefersSequences() #11270

New Issue

admin · 2026-01-22T16:10:14+01:00

admin commented

2026-01-22 16:10:14 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/8942

State: closed
Merged: Yes

This PR removes one call to prefersSequences() that slipped my eye. Here it is used to skip a test for platforms that don't "prefer" sequences.

While that test certainly was meant to reproduce a bug that occurred with sequences, I'm unsure if we really need to skip it in other environments.

**Original Pull Request:** https://github.com/doctrine/orm/pull/8942 **State:** closed **Merged:** Yes --- This PR removes one call to `prefersSequences()` that slipped my eye. Here it is used to skip a test for platforms that don't "prefer" sequences. While that test certainly was meant to reproduce a bug that occurred with sequences, I'm unsure if we really need to skip it in other environments.

admin added the pull-request label 2026-01-22 16:10:14 +01:00

admin referenced this issue

2026-01-22 16:15:32 +01:00

[PR #11270] Treat '0' as a legitimate trim char #12900

Sign in to join this conversation.