[PR #8897] Redeclare $_attributes property in Configuration class. #11235

Open
opened 2026-01-22 16:10:07 +01:00 by admin · 0 comments
Owner

Original Pull Request: https://github.com/doctrine/orm/pull/8897

State: closed
Merged: Yes


Hello.

doctrine/dbal:3.x removed $_attributes property in a Configuration class that we are extending in: 5d03f6e443

Lets redeclare it to keep backward compatibility and fix 65 of ot 110 following Psalm errors.

ERROR: UndefinedThisPropertyFetch - lib/Doctrine/ORM/Configuration.php:66:9 - Instance property Doctrine\ORM\Configuration::$_attributes is not defined (see https://psalm.dev/041)
        $this->_attributes['proxyDir'] = $dir;


ERROR: UndefinedThisPropertyAssignment - lib/Doctrine/ORM/Configuration.php:66:9 - Instance property Doctrine\ORM\Configuration::$_attributes is not defined (see https://psalm.dev/040)
        $this->_attributes['proxyDir'] = $dir;

As a next step - I think we should deprecate usage of this property 2.10 and start using separate properties in 3.x similar to doctrine/dbal.

**Original Pull Request:** https://github.com/doctrine/orm/pull/8897 **State:** closed **Merged:** Yes --- Hello. doctrine/dbal:3.x removed `$_attributes` property in a `Configuration` class that we are extending in: https://github.com/doctrine/dbal/commit/5d03f6e443e8d444bf9917ca44b1b553ecaa4896 Lets redeclare it to keep backward compatibility and fix 65 of ot 110 following Psalm errors. ``` ERROR: UndefinedThisPropertyFetch - lib/Doctrine/ORM/Configuration.php:66:9 - Instance property Doctrine\ORM\Configuration::$_attributes is not defined (see https://psalm.dev/041) $this->_attributes['proxyDir'] = $dir; ERROR: UndefinedThisPropertyAssignment - lib/Doctrine/ORM/Configuration.php:66:9 - Instance property Doctrine\ORM\Configuration::$_attributes is not defined (see https://psalm.dev/040) $this->_attributes['proxyDir'] = $dir; ``` As a next step - I think we should deprecate usage of this property 2.10 and start using separate properties in 3.x similar to doctrine/dbal.
admin added the pull-request label 2026-01-22 16:10:07 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#11235