[PR #8836] Make implicit type casts explicit #11200

New Issue

admin · 2026-01-22T16:10:01+01:00

admin commented

2026-01-22 16:10:01 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/8836

State: closed
Merged: Yes

Before we discuss what target branch the strict_types PR should use, here is a PR that makes 2.10.x compatible with strict types.
Everything was pretty straightforward except the sequence generator which is full of casts from int to string and vice versa. After reading https://github.com/doctrine/orm/pull/6683 , it seems to me that we want to be compatible with sequences greater than PHP_INT_MAX, but I doubt we are in practice.
Note how this reduces the baseline.

**Original Pull Request:** https://github.com/doctrine/orm/pull/8836 **State:** closed **Merged:** Yes --- Before we discuss what target branch the `strict_types` PR should use, here is a PR that makes 2.10.x compatible with strict types. Everything was pretty straightforward except the sequence generator which is full of casts from int to string and _vice versa_. After reading https://github.com/doctrine/orm/pull/6683 , it seems to me that we want to be compatible with sequences greater than PHP_INT_MAX, but I doubt we are in practice. Note how this reduces the baseline.

admin added the pull-request label 2026-01-22 16:10:01 +01:00

admin referenced this issue

2026-01-22 16:15:23 +01:00

[PR #11200] Ignore subclasses without discriminatorValue when generating discriminator column condition SQL #12849

admin referenced this issue

2026-01-22 16:15:25 +01:00

[PR #11213] Factor out finding discriminator values for a class #12859

Sign in to join this conversation.