[PR #8640] FileLockRegion::__construct 3rd param is meant to be an int #11099

New Issue

admin · 2026-01-22T16:09:43+01:00

admin commented

2026-01-22 16:09:43 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/8640

State: closed
Merged: Yes

Following https://github.com/doctrine/orm/pull/8630#discussion_r615421792, this is a proper PR that propose changing the type of the param to an int.

This is kinda a BC break because while the code and behaviour doesn't change, it technically modify the expected type.

Note that before #8630, every value given internally was effectively an int.

**Original Pull Request:** https://github.com/doctrine/orm/pull/8640 **State:** closed **Merged:** Yes --- Following https://github.com/doctrine/orm/pull/8630#discussion_r615421792, this is a proper PR that propose changing the type of the param to an int. This is kinda a BC break because while the code and behaviour doesn't change, it technically modify the expected type. Note that before #8630, every value given internally was effectively an int.

admin added the pull-request label 2026-01-22 16:09:44 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#11099