[PR #8627] Add baseline files for static analyzers #11092

New Issue

admin · 2026-01-22T16:09:42+01:00

admin commented

2026-01-22 16:09:42 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/8627

State: closed
Merged: Yes

There are many CS and SA-related changes in the ORM as we pursue better
code quality, and easier contributions. These often involve huge
changes, which can be hard to review and inevitably lead to some
regressions. I know some of those could have been avoided if we were
using stricter levels for PHPStan and Psalm.

By adding baselines, we ensure new code is at level 5 for both tools,
which should allow us to catch the most interesting issues.

⚠️ I think what follows might be a fallacy know as "appeal to authority" , but both @ondrejmirtes and @muglug recommended this to us in #7691 and #8624

Also note that is comparable to what we have been previously doing with https://github.com/diff-sniffer/diff-sniffer for the CS

**Original Pull Request:** https://github.com/doctrine/orm/pull/8627 **State:** closed **Merged:** Yes --- There are many CS and SA-related changes in the ORM as we pursue better code quality, and easier contributions. These often involve huge changes, which can be hard to review and inevitably lead to some regressions. I know some of those could have been avoided if we were using stricter levels for PHPStan and Psalm. By adding baselines, we ensure new code is at level 5 for both tools, which should allow us to catch the most interesting issues. ⚠️ I think what follows might be a fallacy know as "appeal to authority" , but both @ondrejmirtes and @muglug recommended this to us in #7691 and #8624 Also note that is comparable to what we have been previously doing with https://github.com/diff-sniffer/diff-sniffer for the CS

admin added the pull-request label 2026-01-22 16:09:42 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#11092