[PR #8544] Add type declarations where backwards-compatible #11058

New Issue

admin · 2026-01-22T16:09:34+01:00

admin commented

2026-01-22 16:09:34 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/8544

State: closed
Merged: Yes

This includes:

private methods
return type declarations of final protected methods
return type declarations of public and protected methods of final classes

Parameter type declarations are a more delicate matter and should
probably be handled separately to make it easier to catch issues during
code review.

Type declarations can be more trusted than simple phpdoc when it
comes to static analysis, having them means we can infer the phpdoc of
calling methods with confidence.

Note that it seems that some of the phpdoc I initially inferred these
declarations from were apparently wrong, in particular some mentioning
Doctrine\Dbal\Statement when was is really passed around is
Doctrine\Dbal\Driver\Statement.

Closes #8538

**Original Pull Request:** https://github.com/doctrine/orm/pull/8544 **State:** closed **Merged:** Yes --- This includes: - private methods - return type declarations of final protected methods - return type declarations of public and protected methods of final classes Parameter type declarations are a more delicate matter and should probably be handled separately to make it easier to catch issues during code review. Type declarations can be more trusted than simple phpdoc when it comes to static analysis, having them means we can infer the phpdoc of calling methods with confidence. Note that it seems that some of the phpdoc I initially inferred these declarations from were apparently wrong, in particular some mentioning `Doctrine\Dbal\Statement` when was is really passed around is `Doctrine\Dbal\Driver\Statement`. Closes #8538

admin added the pull-request label 2026-01-22 16:09:34 +01:00

admin closed this issue

2026-01-22 16:09:35 +01:00

admin referenced this issue

2026-01-22 16:15:09 +01:00

[PR #11058] fix: ordering of the edges regardless when the parent node is persisted #12782

admin referenced this issue

2026-01-22 16:15:11 +01:00

[PR #11086] Avoid an inconsistency in topological sort result order #12793

Sign in to join this conversation.