[PR #8533] Add test coverage for passing optimistic lock version as string #11049

New Issue

admin · 2026-01-22T16:09:33+01:00

admin commented

2026-01-22 16:09:33 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/8533

State: closed
Merged: Yes

As suggested by @greg0ire I have updated the tests to cover the current behaviour of passing a string version argument for optimistic locking.

Since #8527 was only-sort-of-a-bug and this is just a simple variation of how ->lock is already tested, I thought it made sense to modify the existing tests to cover this case rather than the overhead of a whole separate test case. Particularly since I guess this will probably change again in a future release, and the goal is just to avoid that happening accidentally in the meantime.

If you'd prefer to have a standalone GH8527 ticket test instead I can happily do that, just let me know.

**Original Pull Request:** https://github.com/doctrine/orm/pull/8533 **State:** closed **Merged:** Yes --- As suggested by @greg0ire I have updated the tests to cover the current behaviour of passing a string `version` argument for optimistic locking. Since #8527 was only-sort-of-a-bug and this is just a simple variation of how `->lock` is already tested, I thought it made sense to modify the existing tests to cover this case rather than the overhead of a whole separate test case. Particularly since I guess this will probably change again in a future release, and the goal is just to avoid that happening accidentally in the meantime. If you'd prefer to have a standalone GH8527 ticket test instead I can happily do that, just let me know.

admin added the pull-request label 2026-01-22 16:09:33 +01:00

admin closed this issue

2026-01-22 16:09:33 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#11049