doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #8439] Use typed properties for default metadata for #7939 #10990

New Issue
Closed
opened 2026-01-22 16:09:19 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:09:19 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/8439

State: closed
Merged: Yes

This is simple implementation of idea outlined in #7939. During completion step of a field mapping completion or association mapping completion it looks for typed property and, when existent, uses it to determine default for type, targetEntity and nullable (in fields and joinTable).

I have added simple tests covering all cases I found.

I am not a great fan of encapsulating code in PHP_VERSION_ID >= 70400, but at the time of writing got no better idea.

I couldn't get master branch to work locally and that's the only reason why I target '2.9.x' (Composer has problem resolving doctrine/dbal).

This is my first PR to Doctrine project, so if anything is done wrong please let me know and I will do my best to fix it :)

**Original Pull Request:** https://github.com/doctrine/orm/pull/8439 **State:** closed **Merged:** Yes --- This is simple implementation of idea outlined in #7939. During completion step of a field mapping completion or association mapping completion it looks for typed property and, when existent, uses it to determine default for `type`, `targetEntity` and `nullable` (in fields and `joinTable`). I have added simple tests covering all cases I found. I am not a great fan of encapsulating code in `PHP_VERSION_ID >= 70400`, but at the time of writing got no better idea. I couldn't get master branch to work locally and that's the only reason why I target '2.9.x' (Composer has problem resolving doctrine/dbal). This is my first PR to Doctrine project, so if anything is done wrong please let me know and I will do my best to fix it :)
admin added the pull-request label 2026-01-22 16:09:19 +01:00
admin closed this issue 2026-01-22 16:09:19 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#10990
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?