mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
[PR #8347] Add doctrine/dbal 3 support #10940
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/doctrine/orm/pull/8347
State: closed
Merged: No
Hi all,
This is a first attempt into having DBAL 3 support on the 2.x ORM branches. There are some things that should we discussed, namely:
Some Platforms do no longer exist on DBAL (
PostgreSqlPlatfrom,PostgreSql91Platfrom,PostgreSql92Platfrom,SQLServerPlatform,SQLServer2005Platform,SQLServer2008Platform). As DBAL is most of the times fetched as a dependency of ORM this can be a problem if someone still relies on those platforms. Not sure if this should be considered a BC-break, and hence DBAL 3 would not be possible on ORM 2. Some tests that relied on those platforms have then changed.Some methods that the ORM uses are no longer present on DBAL 3, namely
AbstractPlatform::prefersSequences(),AbstractPlatform::getSQLResultCasing()andAbstractPlatform::fixSchemaElementName(). ForprefersSequencesI think I have found an acceptable workaround that should not break anything. ForgetSQLResultCasingI have created a newSQLResultCaserclass to do it, same withfixSchemaElementName()and a newSchemaElementNameFixer. See the discussion with @morozov on https://github.com/doctrine/dbal/pull/4229Should we trigger deprecation warnings somewhere?
Tests pass with both DBAL 2 and DBAL 3. I have raised the minimum DBAL version to 2.12.