doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #8284] rename parameters to match parents #10893

New Issue
Open
opened 2026-01-22 16:09:02 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:09:02 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/8284

State: closed
Merged: Yes

Hi,

This PR propose changing parameter names when they don't match parents.

This is suggested by the lastest version of Psalm in preparation for PHP 8 named arguments.

Here is the rationale: https://psalm.dev/docs/running_psalm/issues/ParamNameMismatch/

This may not be something we care about or that we want to support. In that case, I will change Psalm's config to ignore those in the future.

I don't believe changing parameter names is a BC break for now so we may want to do this now rather than a few months down when PHP8 will be available.

**Original Pull Request:** https://github.com/doctrine/orm/pull/8284 **State:** closed **Merged:** Yes --- Hi, This PR propose changing parameter names when they don't match parents. This is suggested by the lastest version of Psalm in preparation for PHP 8 named arguments. Here is the rationale: https://psalm.dev/docs/running_psalm/issues/ParamNameMismatch/ This may not be something we care about or that we want to support. In that case, I will change Psalm's config to ignore those in the future. I don't believe changing parameter names is a BC break for now so we may want to do this now rather than a few months down when PHP8 will be available.
admin added the pull-request label 2026-01-22 16:09:02 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#10893
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?