doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #7614] Allow to escape reserved words in xml mapping #10573

New Issue
Closed
opened 2026-01-22 16:08:00 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:08:00 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/7614

State: closed
Merged: No

When escaping reserved words in XML mapping XSD validation fails. This PR uses regex to allow backticks. This regex is also much more restrictive than xs:NMTOKEN, let me know if that's not okay.

<field name="email" column="`user_email`" type="string" column-definition="CHAR(32) NOT NULL" />

Any advice in terms of tests? I went over #7324, #6728 and got a bit confused. As far as I understand, #6728 will introduce functionality that can be used in tests, and all XSD related PRs are waiting for that to be merged. Did I get it right?

**Original Pull Request:** https://github.com/doctrine/orm/pull/7614 **State:** closed **Merged:** No --- When escaping reserved words in XML mapping XSD validation fails. This PR uses regex to allow backticks. This regex is also much more restrictive than `xs:NMTOKEN`, let me know if that's not okay. ``` <field name="email" column="`user_email`" type="string" column-definition="CHAR(32) NOT NULL" /> ``` Any advice in terms of tests? I went over #7324, #6728 and got a bit confused. As far as I understand, #6728 will introduce functionality that can be used in tests, and all XSD related PRs are waiting for that to be merged. Did I get it right?
admin added the pull-request label 2026-01-22 16:08:00 +01:00
admin closed this issue 2026-01-22 16:08:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#10573
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?