doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #7296] Fix #7286: StringPrimary no longer accepts aggregate functions as argument #10410

New Issue
Open
opened 2026-01-22 16:07:26 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:07:26 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/7296

State: closed
Merged: Yes

866418e40f (#6500) removed special-casing of aggregate functions.
This was mostly transparent for cases where isAggregateFunction() is used, but not in StringPrimary which doesn't use isAggregateFunction() to detect the function ahead.
Since these functions (still) have separate tokens, they're not recognized as T_IDENTIFIER in StringPrimary, thus not handled as generic FunctionDeclaration.

Fixes #7286.

**Original Pull Request:** https://github.com/doctrine/orm/pull/7296 **State:** closed **Merged:** Yes --- 866418e40f38e33f2c5dcf16ab9bccd3cdffa563 (#6500) removed special-casing of aggregate functions. This was mostly transparent for cases where `isAggregateFunction()` is used, but not in StringPrimary which doesn't use `isAggregateFunction()` to detect the function ahead. Since these functions (still) have separate tokens, they're not recognized as T_IDENTIFIER in StringPrimary, thus not handled as generic FunctionDeclaration. Fixes #7286.
admin added the pull-request label 2026-01-22 16:07:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#10410
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?