mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
[PR #7180] commit order must consider non-nullability of join columns as prioritised over nullable join columns: Take 2 #10359
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/doctrine/orm/pull/7180
State: closed
Merged: No
This is a resubmission of https://github.com/doctrine/doctrine2/pull/6533, which attempted to fix https://github.com/doctrine/doctrine2/issues/6499 (also https://github.com/doctrine/doctrine2/issues/7006)
Note that that I consulted Marco on slack before doing this.
I don't want to step on anyones toes, but the original PR has seemed to have gone stale and come to a halt. Maybe the original submitter has lost interest/moved on (his fork appears to be gone) or whatever (not judging), but regardless, I'd like to pick this back again and try and get it over the line.
I've maintained the original commits from the PR as well as some of Marco's styling fixes.
#6533 was merged and then reverted (https://github.com/doctrine/doctrine2/pull/6533#issuecomment-321911821).
The Tests reveal the problem,
CascadeRemoveOrderTest. If anyone has any idea how this can be fixed before I start poking around, please give me a heads up.