[PR #6964] [CS] Ported lib/ to updated CS 2.0 #10247

New Issue

admin · 2026-01-22T16:06:56+01:00

admin commented

2026-01-22 16:06:56 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/6964

State: closed
Merged: Yes

Beware, tons of changes. Most of them automatically fixed by phpcbf.

Most of the changes should be harmless except some weak->strict comparison changes (one was kept because juggling is part of expected behavior (really), hopefully we can eliminate it later by explicit casts).

Disabled:

native parameter and return type declaration checks - BC breaking, will do in phase two (needs to be propagated to common libs as well)
Throwable check - Exception is still used on multiple places

Tried to narrow down as many iterables and mixeds as possible (manually), but it's still a mixed land more than I'd like. (Whoever invented wide array type in phpDoc standard killed some kittens btw.)

Made lib/ check mandatory on CI (although now irrelevant until we fix CI).
https://travis-ci.org/doctrine/doctrine2/jobs/325277840

∑ 3,599 additions, 7,202 deletions.

Future scope:

rebase?
port tests/
native parameters and native types, moving from phpDoc to native declaration

**Original Pull Request:** https://github.com/doctrine/orm/pull/6964 **State:** closed **Merged:** Yes --- Beware, tons of changes. Most of them automatically fixed by phpcbf. Most of the changes should be harmless except some weak->strict comparison changes (one was kept because juggling is part of expected behavior (really), hopefully we can eliminate it later by explicit casts). Disabled: * native parameter and return type declaration checks - BC breaking, will do in phase two (needs to be propagated to common libs as well) * Throwable check - Exception is still used on multiple places Tried to narrow down as many iterables and mixeds as possible (manually), but it's still a mixed land more than I'd like. (Whoever invented wide `array` type in phpDoc standard killed some kittens btw.) Made lib/ check mandatory on CI (although now irrelevant until we fix CI). https://travis-ci.org/doctrine/doctrine2/jobs/325277840 ∑ 3,599 additions, 7,202 deletions. Future scope: * rebase? * port tests/ * native parameters and native types, moving from phpDoc to native declaration

admin added the pull-request label 2026-01-22 16:06:56 +01:00

admin referenced this issue

2026-01-22 16:13:18 +01:00

[PR #10247] Fix types for Paginator #12211

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#10247