mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
[PR #6623] Ensure that AbstractHydrator#hydrateAll() detaches the hydrator from the event manager
#10073
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/doctrine/orm/pull/6623
State: closed
Merged: Yes
I think someone overlooked hydrateAll() method and edited only iterate(). https://github.com/doctrine/doctrine2/pull/1515
As a result an event listener is not added which can cause problems if EventManager implementation does not check for existence of a listener upon its removal.
In my case it causes E_NOTICE (undefined index) because of https://github.com/Kdyby/Events/blob/master/src/Events/EventManager.php#L198
If my PR should be altered (commit message, etc.) please let me know.