doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #6616] #6613 #6614 correct handling of new elements added to an initialized (yet dirty) collection #10067

New Issue
Open
opened 2026-01-22 16:06:19 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:06:19 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/6616

State: closed
Merged: Yes

Fixes #6613
Fixes #6614

This is a very bad bug. The fix introduces some ovehead, but the scenario is usually not that common, so it should be fine.

Ideally, we should keep new and dirty states completely separate, but that's not possible without completely changing also the base class (Doctrine\Common\Collections\AbstractLazyCollection)

**Original Pull Request:** https://github.com/doctrine/orm/pull/6616 **State:** closed **Merged:** Yes --- Fixes #6613 Fixes #6614 This is a *very* bad bug. The fix introduces some ovehead, but the scenario is usually not that common, so it should be fine. Ideally, we should keep `new` and `dirty` states completely separate, but that's not possible without completely changing also the base class (`Doctrine\Common\Collections\AbstractLazyCollection`)
admin added the pull-request label 2026-01-22 16:06:19 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#10067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?