doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #6554] Move identifier generation to FieldMetadata #10031

New Issue
Open
opened 2026-01-22 16:06:12 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:06:12 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/6554

State: closed
Merged: Yes

Removed ClassMetadata::$generatorType, ClassMetadata::$generatorDefinition and ClassMetadata::$idGenerator and related methods.

Some pieces of code (UoW in particular) are not really nice because of original assumptions about single vs. composite keys and generator types, but it'll eventually undergo further reactorings and generalization soon with introduction of ValueGenerationPlan...

Removed two tests:

  • Functional\Ticket\DDC2415Test - tested id generator inheritance which no longer exists
  • Mapping\ClassMetadataTest::testSetSequenceGeneratorThrowsExceptionWhenSequenceNameIsMissing - tested setGeneratorDefinition() method that was removed

Default test suite passes, test suite w/ postgres has same number of failures compared to develop.

Working version of #6551.

**Original Pull Request:** https://github.com/doctrine/orm/pull/6554 **State:** closed **Merged:** Yes --- Removed ClassMetadata::$generatorType, ClassMetadata::$generatorDefinition and ClassMetadata::$idGenerator and related methods. Some pieces of code (UoW in particular) are not really nice because of original assumptions about single vs. composite keys and generator types, but it'll eventually undergo further reactorings and generalization soon with introduction of ValueGenerationPlan... Removed two tests: * Functional\Ticket\DDC2415Test - tested id generator inheritance which no longer exists * Mapping\ClassMetadataTest::testSetSequenceGeneratorThrowsExceptionWhenSequenceNameIsMissing - tested setGeneratorDefinition() method that was removed Default test suite passes, test suite w/ postgres has same number of failures compared to develop. _Working version of #6551._
admin added the pull-request label 2026-01-22 16:06:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#10031
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?