doctrine/KeyValueStore
1
0
Fork 0
mirror of https://github.com/doctrine/KeyValueStore.git synced 2026-03-24 08:42:12 +01:00
Code Issues 46 Packages Projects Releases 2 Wiki Activity

[PR #62] [MERGED] Coding tools #91

New Issue
Closed
opened 2026-01-23 11:35:10 +01:00 by admin · 0 comments
admin commented 2026-01-23 11:35:10 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/KeyValueStore/pull/62
Author: @EmanueleMinotto
Created: 12/13/2015
Status: ✅ Merged
Merged: 12/13/2015
Merged by: @Ocramius

Base: master ← Head: enhancement/coding-tools

📝 Commits (4)

  • f2ef7d7 added editorconfig configuration
  • 8248672 added php-ca-fixer configuration
  • a3827e9 php-cs round
  • 50de140 prevent complex (curly) syntax

📊 Changes

65 files changed (+926 additions, -460 deletions)

View changed files

➕ .editorconfig (+15 -0)
➕ .php_cs (+83 -0)
📝 docs/reference/basic-usage.rst (+1 -1)
📝 docs/reference/configuration.rst (+2 -2)
📝 lib/Doctrine/KeyValueStore/Configuration.php (+9 -5)
📝 lib/Doctrine/KeyValueStore/EntityManager.php (+7 -7)
📝 lib/Doctrine/KeyValueStore/Http/Client.php (+6 -3)
📝 lib/Doctrine/KeyValueStore/Http/Response.php (+5 -2)
📝 lib/Doctrine/KeyValueStore/Http/SocketClient.php (+16 -12)
📝 lib/Doctrine/KeyValueStore/Id/CompositeIdHandler.php (+6 -5)
📝 lib/Doctrine/KeyValueStore/Id/IdConverterStrategy.php (+1 -0)
📝 lib/Doctrine/KeyValueStore/Id/IdHandlingStrategy.php (+6 -2)
📝 lib/Doctrine/KeyValueStore/Id/NullIdConverter.php (+1 -0)
📝 lib/Doctrine/KeyValueStore/Id/SingleIdHandler.php (+1 -0)
📝 lib/Doctrine/KeyValueStore/KeyValueStoreException.php (+2 -1)
📝 lib/Doctrine/KeyValueStore/Mapping/AnnotationDriver.php (+8 -6)
📝 lib/Doctrine/KeyValueStore/Mapping/Annotations/Entity.php (+1 -0)
📝 lib/Doctrine/KeyValueStore/Mapping/Annotations/Id.php (+1 -0)
📝 lib/Doctrine/KeyValueStore/Mapping/Annotations/Transient.php (+1 -0)
📝 lib/Doctrine/KeyValueStore/Mapping/ClassMetadata.php (+17 -7)

...and 45 more files

📄 Description

Added a couple of coding tools:

  • editorconfig: I'm usually against editors/IDEs specific configuration contained in a repo, but editorconfig is a simple and really common configuration system, so imo could be included
  • php-cs-fixer: I tried to follow https://github.com/doctrine/coding-standard while writing the list of included fixers

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/KeyValueStore/pull/62 **Author:** [@EmanueleMinotto](https://github.com/EmanueleMinotto) **Created:** 12/13/2015 **Status:** ✅ Merged **Merged:** 12/13/2015 **Merged by:** [@Ocramius](https://github.com/Ocramius) **Base:** `master` ← **Head:** `enhancement/coding-tools` --- ### 📝 Commits (4) - [`f2ef7d7`](https://github.com/doctrine/KeyValueStore/commit/f2ef7d7445d389ddddc767870c16d3e10b43260d) added editorconfig configuration - [`8248672`](https://github.com/doctrine/KeyValueStore/commit/82486729dde4e0d0e05ff8364e03918f01348590) added php-ca-fixer configuration - [`a3827e9`](https://github.com/doctrine/KeyValueStore/commit/a3827e94b6138e3cf774a59ba46ad2eeba90ba3b) php-cs round - [`50de140`](https://github.com/doctrine/KeyValueStore/commit/50de14012ffa23c467b98d7da33ce088520617d6) prevent complex (curly) syntax ### 📊 Changes **65 files changed** (+926 additions, -460 deletions) <details> <summary>View changed files</summary> ➕ `.editorconfig` (+15 -0) ➕ `.php_cs` (+83 -0) 📝 `docs/reference/basic-usage.rst` (+1 -1) 📝 `docs/reference/configuration.rst` (+2 -2) 📝 `lib/Doctrine/KeyValueStore/Configuration.php` (+9 -5) 📝 `lib/Doctrine/KeyValueStore/EntityManager.php` (+7 -7) 📝 `lib/Doctrine/KeyValueStore/Http/Client.php` (+6 -3) 📝 `lib/Doctrine/KeyValueStore/Http/Response.php` (+5 -2) 📝 `lib/Doctrine/KeyValueStore/Http/SocketClient.php` (+16 -12) 📝 `lib/Doctrine/KeyValueStore/Id/CompositeIdHandler.php` (+6 -5) 📝 `lib/Doctrine/KeyValueStore/Id/IdConverterStrategy.php` (+1 -0) 📝 `lib/Doctrine/KeyValueStore/Id/IdHandlingStrategy.php` (+6 -2) 📝 `lib/Doctrine/KeyValueStore/Id/NullIdConverter.php` (+1 -0) 📝 `lib/Doctrine/KeyValueStore/Id/SingleIdHandler.php` (+1 -0) 📝 `lib/Doctrine/KeyValueStore/KeyValueStoreException.php` (+2 -1) 📝 `lib/Doctrine/KeyValueStore/Mapping/AnnotationDriver.php` (+8 -6) 📝 `lib/Doctrine/KeyValueStore/Mapping/Annotations/Entity.php` (+1 -0) 📝 `lib/Doctrine/KeyValueStore/Mapping/Annotations/Id.php` (+1 -0) 📝 `lib/Doctrine/KeyValueStore/Mapping/Annotations/Transient.php` (+1 -0) 📝 `lib/Doctrine/KeyValueStore/Mapping/ClassMetadata.php` (+17 -7) _...and 45 more files_ </details> ### 📄 Description Added a couple of coding tools: - editorconfig: I'm usually against editors/IDEs specific configuration contained in a repo, but editorconfig is a simple and [really common](http://editorconfig.org/#download) configuration system, so imo could be included - php-cs-fixer: I tried to follow https://github.com/doctrine/coding-standard while writing the list of included fixers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-23 11:35:10 +01:00
admin closed this issue 2026-01-23 11:35:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bc break
bug
bug
docs
enhancement
feature
pull-request
Mirrored from GitHub Pull Request
 rfc
won't fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/KeyValueStore#91
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?