doctrine/KeyValueStore
1
0
Fork 0
mirror of https://github.com/doctrine/KeyValueStore.git synced 2026-03-24 08:42:12 +01:00
Code Issues 46 Packages Projects Releases 2 Wiki Activity

[PR #36] [MERGED] Mapping drivers #73

New Issue
Closed
opened 2026-01-23 11:35:06 +01:00 by admin · 0 comments
admin commented 2026-01-23 11:35:06 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/KeyValueStore/pull/36
Author: @EmanueleMinotto
Created: 10/9/2015
Status: ✅ Merged
Merged: 10/10/2015
Merged by: @beberlei

Base: master ← Head: drivers

📝 Commits (8)

  • 00c8e1f changed annotations namespace to follow doctrine/doctrine2
  • 0f6efb7 added YAML driver (+ tests)
  • 927fc52 temporary solution
  • 32d528d moved yaml fixtures
  • 67e44a7 added xml driver
  • 32e017b reverted annotations namespace
  • dd3a9e6 reverted drivers namespace
  • 6b26ceb alias not required

📊 Changes

18 files changed (+384 additions, -25 deletions)

View changed files

📝 lib/Doctrine/KeyValueStore/Mapping/AnnotationDriver.php (+12 -1)
📝 lib/Doctrine/KeyValueStore/Mapping/Annotations/Entity.php (+2 -1)
📝 lib/Doctrine/KeyValueStore/Mapping/Annotations/Id.php (+2 -1)
📝 lib/Doctrine/KeyValueStore/Mapping/Annotations/Transient.php (+2 -1)
➕ lib/Doctrine/KeyValueStore/Mapping/XmlDriver.php (+119 -0)
➕ lib/Doctrine/KeyValueStore/Mapping/YamlDriver.php (+103 -0)
📝 tests/Doctrine/Tests/KeyValueStore/Functional/BasicCrudTestCase.php (+39 -6)
📝 tests/Doctrine/Tests/KeyValueStore/Functional/InheritanceTest.php (+14 -5)
📝 tests/Doctrine/Tests/KeyValueStore/Functional/PersistTest.php (+24 -6)
📝 tests/Doctrine/Tests/KeyValueStoreTestCase.php (+18 -4)
➕ tests/Doctrine/Tests/fixtures/xml/Doctrine.Tests.KeyValueStore.Functional.ChildEntity.dcm.xml (+9 -0)
➕ tests/Doctrine/Tests/fixtures/xml/Doctrine.Tests.KeyValueStore.Functional.ParentEntity.dcm.xml (+9 -0)
➕ tests/Doctrine/Tests/fixtures/xml/Doctrine.Tests.KeyValueStore.Functional.PersistEntity.dcm.xml (+9 -0)
➕ tests/Doctrine/Tests/fixtures/xml/Doctrine.Tests.KeyValueStore.Functional.Post.dcm.xml (+9 -0)
➕ tests/Doctrine/Tests/fixtures/yaml/Doctrine.Tests.KeyValueStore.Functional.ChildEntity.dcm.yml (+3 -0)
➕ tests/Doctrine/Tests/fixtures/yaml/Doctrine.Tests.KeyValueStore.Functional.ParentEntity.dcm.yml (+3 -0)
➕ tests/Doctrine/Tests/fixtures/yaml/Doctrine.Tests.KeyValueStore.Functional.PersistEntity.dcm.yml (+3 -0)
➕ tests/Doctrine/Tests/fixtures/yaml/Doctrine.Tests.KeyValueStore.Functional.Post.dcm.yml (+4 -0)

📄 Description

Should be a solution (a first draft at least) for #12 and #13

<!-- Doctrine.Tests.KeyValueStore.Functional.Post.dcm.xml -->
<?xml version="1.0" encoding="UTF-8"?>
<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping
                          http://raw.github.com/doctrine/doctrine2/master/doctrine-mapping.xsd">
    <entity name="Doctrine\Tests\KeyValueStore\Functional\Post" storage-name="post">
        <id>id</id>
    </entity>
</doctrine-mapping>

# Doctrine.Tests.KeyValueStore.Functional.Post.dcm.yml
Doctrine\Tests\KeyValueStore\Functional\Post:
  storageName: post
  id:
    - id
  transient:
    - foo
    - bar

The identifier can also be a string. A single attribute as identifier should be a common thing (I think).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/KeyValueStore/pull/36 **Author:** [@EmanueleMinotto](https://github.com/EmanueleMinotto) **Created:** 10/9/2015 **Status:** ✅ Merged **Merged:** 10/10/2015 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `drivers` --- ### 📝 Commits (8) - [`00c8e1f`](https://github.com/doctrine/KeyValueStore/commit/00c8e1fa46e37d12a00c3c1ebe4451f8d7dd8354) changed annotations namespace to follow doctrine/doctrine2 - [`0f6efb7`](https://github.com/doctrine/KeyValueStore/commit/0f6efb76f9bfef6500b3d261b5a5e2c352207798) added YAML driver (+ tests) - [`927fc52`](https://github.com/doctrine/KeyValueStore/commit/927fc5219389f62f34c973ae117877ab5bc8d05a) temporary solution - [`32d528d`](https://github.com/doctrine/KeyValueStore/commit/32d528d02a28ef52930745b6f7570971e4c7986e) moved yaml fixtures - [`67e44a7`](https://github.com/doctrine/KeyValueStore/commit/67e44a7683caf67bdacb7fd52be79a9901626a7d) added xml driver - [`32e017b`](https://github.com/doctrine/KeyValueStore/commit/32e017b58de3bbe38e39865aaa89c740042f41e3) reverted annotations namespace - [`dd3a9e6`](https://github.com/doctrine/KeyValueStore/commit/dd3a9e6c9e29b06cc7296aded40e60f6ca226682) reverted drivers namespace - [`6b26ceb`](https://github.com/doctrine/KeyValueStore/commit/6b26ceb2843d6ffc67016d2ed8f447a65e567216) alias not required ### 📊 Changes **18 files changed** (+384 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/KeyValueStore/Mapping/AnnotationDriver.php` (+12 -1) 📝 `lib/Doctrine/KeyValueStore/Mapping/Annotations/Entity.php` (+2 -1) 📝 `lib/Doctrine/KeyValueStore/Mapping/Annotations/Id.php` (+2 -1) 📝 `lib/Doctrine/KeyValueStore/Mapping/Annotations/Transient.php` (+2 -1) ➕ `lib/Doctrine/KeyValueStore/Mapping/XmlDriver.php` (+119 -0) ➕ `lib/Doctrine/KeyValueStore/Mapping/YamlDriver.php` (+103 -0) 📝 `tests/Doctrine/Tests/KeyValueStore/Functional/BasicCrudTestCase.php` (+39 -6) 📝 `tests/Doctrine/Tests/KeyValueStore/Functional/InheritanceTest.php` (+14 -5) 📝 `tests/Doctrine/Tests/KeyValueStore/Functional/PersistTest.php` (+24 -6) 📝 `tests/Doctrine/Tests/KeyValueStoreTestCase.php` (+18 -4) ➕ `tests/Doctrine/Tests/fixtures/xml/Doctrine.Tests.KeyValueStore.Functional.ChildEntity.dcm.xml` (+9 -0) ➕ `tests/Doctrine/Tests/fixtures/xml/Doctrine.Tests.KeyValueStore.Functional.ParentEntity.dcm.xml` (+9 -0) ➕ `tests/Doctrine/Tests/fixtures/xml/Doctrine.Tests.KeyValueStore.Functional.PersistEntity.dcm.xml` (+9 -0) ➕ `tests/Doctrine/Tests/fixtures/xml/Doctrine.Tests.KeyValueStore.Functional.Post.dcm.xml` (+9 -0) ➕ `tests/Doctrine/Tests/fixtures/yaml/Doctrine.Tests.KeyValueStore.Functional.ChildEntity.dcm.yml` (+3 -0) ➕ `tests/Doctrine/Tests/fixtures/yaml/Doctrine.Tests.KeyValueStore.Functional.ParentEntity.dcm.yml` (+3 -0) ➕ `tests/Doctrine/Tests/fixtures/yaml/Doctrine.Tests.KeyValueStore.Functional.PersistEntity.dcm.yml` (+3 -0) ➕ `tests/Doctrine/Tests/fixtures/yaml/Doctrine.Tests.KeyValueStore.Functional.Post.dcm.yml` (+4 -0) </details> ### 📄 Description Should be a solution (a first draft at least) for #12 and #13 ``` xml <!-- Doctrine.Tests.KeyValueStore.Functional.Post.dcm.xml --> <?xml version="1.0" encoding="UTF-8"?> <doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping http://raw.github.com/doctrine/doctrine2/master/doctrine-mapping.xsd"> <entity name="Doctrine\Tests\KeyValueStore\Functional\Post" storage-name="post"> <id>id</id> </entity> </doctrine-mapping> ``` ``` yaml # Doctrine.Tests.KeyValueStore.Functional.Post.dcm.yml Doctrine\Tests\KeyValueStore\Functional\Post: storageName: post id: - id transient: - foo - bar ``` The identifier can also be a string. A single attribute as identifier should be a common thing (I think). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-23 11:35:06 +01:00
admin closed this issue 2026-01-23 11:35:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bc break
bug
bug
docs
enhancement
feature
pull-request
Mirrored from GitHub Pull Request
 rfc
won't fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/KeyValueStore#73
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?