[PR #33] [MERGED] PHPCS based on doctrine/coding-standard #68

New Issue

admin · 2026-01-23T11:35:05+01:00

admin commented

2026-01-23 11:35:05 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/KeyValueStore/pull/33
Author: @EmanueleMinotto
Created: 8/20/2015
Status: ✅ Merged
Merged: 9/12/2015
Merged by: @beberlei

Base: master ← Head: coding-standard

📝 Commits (2)

d5690b4 PHPCS based on doctrine/coding-standard
e775ffb Inline control structures are not allowed

📊 Changes

34 files changed (+278 additions, -238 deletions)

View changed files

📝 lib/Doctrine/KeyValueStore/Configuration.php (+3 -4)
📝 lib/Doctrine/KeyValueStore/EntityManager.php (+0 -1)
📝 lib/Doctrine/KeyValueStore/Http/Client.php (+1 -2)
📝 lib/Doctrine/KeyValueStore/Http/Response.php (+3 -4)
📝 lib/Doctrine/KeyValueStore/Http/SocketClient.php (+41 -44)
📝 lib/Doctrine/KeyValueStore/Id/CompositeIdHandler.php (+4 -3)
📝 lib/Doctrine/KeyValueStore/Id/IdConverterStrategy.php (+2 -3)
📝 lib/Doctrine/KeyValueStore/Id/IdHandlingStrategy.php (+3 -4)
📝 lib/Doctrine/KeyValueStore/Id/NullIdConverter.php (+0 -1)
📝 lib/Doctrine/KeyValueStore/Id/SingleIdHandler.php (+0 -1)
📝 lib/Doctrine/KeyValueStore/KeyValueStoreException.php (+1 -2)
📝 lib/Doctrine/KeyValueStore/Mapping/AnnotationDriver.php (+12 -7)
📝 lib/Doctrine/KeyValueStore/Mapping/Annotations/Entity.php (+0 -1)
📝 lib/Doctrine/KeyValueStore/Mapping/Annotations/Id.php (+0 -1)
📝 lib/Doctrine/KeyValueStore/Mapping/Annotations/Transient.php (+0 -1)
📝 lib/Doctrine/KeyValueStore/Mapping/ClassMetadata.php (+55 -26)
📝 lib/Doctrine/KeyValueStore/Mapping/ClassMetadataFactory.php (+4 -5)
📝 lib/Doctrine/KeyValueStore/NotFoundException.php (+0 -2)
📝 lib/Doctrine/KeyValueStore/Query/RangeQuery.php (+17 -15)
📝 lib/Doctrine/KeyValueStore/Query/RangeQueryStorage.php (+1 -2)

...and 14 more files

📄 Description

Fixed the coding style with doctrine/coding-standard.
Still missing 2 warnings, but don't know how to replace them.

FILE: lib/Doctrine/KeyValueStore/Storage/WindowsAzureTableStorage.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 48 | WARNING | Line exceeds 120 characters; contains 180 characters
 62 | WARNING | Line exceeds 120 characters; contains 181 characters
--------------------------------------------------------------------------------

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/KeyValueStore/pull/33 **Author:** [@EmanueleMinotto](https://github.com/EmanueleMinotto) **Created:** 8/20/2015 **Status:** ✅ Merged **Merged:** 9/12/2015 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `coding-standard` --- ### 📝 Commits (2) - [`d5690b4`](https://github.com/doctrine/KeyValueStore/commit/d5690b4108645dd0153a266bc12e9dca285b0440) PHPCS based on doctrine/coding-standard - [`e775ffb`](https://github.com/doctrine/KeyValueStore/commit/e775ffbe8f02601a9224ea762854a4b0c979d28c) Inline control structures are not allowed ### 📊 Changes **34 files changed** (+278 additions, -238 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/KeyValueStore/Configuration.php` (+3 -4) 📝 `lib/Doctrine/KeyValueStore/EntityManager.php` (+0 -1) 📝 `lib/Doctrine/KeyValueStore/Http/Client.php` (+1 -2) 📝 `lib/Doctrine/KeyValueStore/Http/Response.php` (+3 -4) 📝 `lib/Doctrine/KeyValueStore/Http/SocketClient.php` (+41 -44) 📝 `lib/Doctrine/KeyValueStore/Id/CompositeIdHandler.php` (+4 -3) 📝 `lib/Doctrine/KeyValueStore/Id/IdConverterStrategy.php` (+2 -3) 📝 `lib/Doctrine/KeyValueStore/Id/IdHandlingStrategy.php` (+3 -4) 📝 `lib/Doctrine/KeyValueStore/Id/NullIdConverter.php` (+0 -1) 📝 `lib/Doctrine/KeyValueStore/Id/SingleIdHandler.php` (+0 -1) 📝 `lib/Doctrine/KeyValueStore/KeyValueStoreException.php` (+1 -2) 📝 `lib/Doctrine/KeyValueStore/Mapping/AnnotationDriver.php` (+12 -7) 📝 `lib/Doctrine/KeyValueStore/Mapping/Annotations/Entity.php` (+0 -1) 📝 `lib/Doctrine/KeyValueStore/Mapping/Annotations/Id.php` (+0 -1) 📝 `lib/Doctrine/KeyValueStore/Mapping/Annotations/Transient.php` (+0 -1) 📝 `lib/Doctrine/KeyValueStore/Mapping/ClassMetadata.php` (+55 -26) 📝 `lib/Doctrine/KeyValueStore/Mapping/ClassMetadataFactory.php` (+4 -5) 📝 `lib/Doctrine/KeyValueStore/NotFoundException.php` (+0 -2) 📝 `lib/Doctrine/KeyValueStore/Query/RangeQuery.php` (+17 -15) 📝 `lib/Doctrine/KeyValueStore/Query/RangeQueryStorage.php` (+1 -2) _...and 14 more files_ </details> ### 📄 Description Fixed the coding style with [doctrine/coding-standard](https://github.com/doctrine/coding-standard). Still missing 2 warnings, but don't know how to replace them. ``` FILE: lib/Doctrine/KeyValueStore/Storage/WindowsAzureTableStorage.php -------------------------------------------------------------------------------- FOUND 0 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S) -------------------------------------------------------------------------------- 48 | WARNING | Line exceeds 120 characters; contains 180 characters 62 | WARNING | Line exceeds 120 characters; contains 181 characters -------------------------------------------------------------------------------- ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-23 11:35:05 +01:00

admin closed this issue

2026-01-23 11:35:05 +01:00

admin referenced this issue

2026-01-23 11:35:11 +01:00

[PR #68] [MERGED] Removed space before logical negation operator #95

admin referenced this issue

2026-01-23 11:35:12 +01:00

[PR #68] Removed space before logical negation operator #98

Sign in to join this conversation.