[PR #29] [MERGED] Fix @Transient annotation -- logic bug plus broken due to typo #61

New Issue

admin · 2026-01-23T11:35:03+01:00

admin commented

2026-01-23 11:35:03 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/KeyValueStore/pull/29
Author: @TheDistantSea
Created: 7/9/2015
Status: ✅ Merged
Merged: 7/9/2015
Merged by: @beberlei

Base: master ← Head: transient-annotation-fixes

📝 Commits (2)

b8f709d Fixing typo that caused fatal error
4bebd86 Fixing logic bug in handling @Transient annotation (it just did nothing at all)

📊 Changes

2 files changed (+4 additions, -1 deletions)

View changed files

📝 lib/Doctrine/KeyValueStore/Mapping/AnnotationDriver.php (+1 -1)
📝 lib/Doctrine/KeyValueStore/Mapping/ClassMetadata.php (+3 -0)

📄 Description

The @Transient annotation simply does not work because

trying to use it dies with trying method call on non-object (due to typo)
there's a logic bug causing the annotation to close the barn door after the horse is gone

This PR fixes both issues.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/KeyValueStore/pull/29 **Author:** [@TheDistantSea](https://github.com/TheDistantSea) **Created:** 7/9/2015 **Status:** ✅ Merged **Merged:** 7/9/2015 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `transient-annotation-fixes` --- ### 📝 Commits (2) - [`b8f709d`](https://github.com/doctrine/KeyValueStore/commit/b8f709dd435aa2001077d0577020f431ab83cecf) Fixing typo that caused fatal error - [`4bebd86`](https://github.com/doctrine/KeyValueStore/commit/4bebd8641701c7e16da3a1a95fb1a567f8915809) Fixing logic bug in handling @Transient annotation (it just did nothing at all) ### 📊 Changes **2 files changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/KeyValueStore/Mapping/AnnotationDriver.php` (+1 -1) 📝 `lib/Doctrine/KeyValueStore/Mapping/ClassMetadata.php` (+3 -0) </details> ### 📄 Description The `@Transient` annotation simply does not work because 1. trying to use it dies with trying method call on non-object (due to typo) 2. there's a logic bug causing the annotation to close the barn door after the horse is gone This PR fixes both issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-23 11:35:03 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/KeyValueStore#61