[PR #16] [MERGED] Add missing use statement and fix query used in DBALStorage. #49

New Issue

admin · 2026-01-23T11:35:02+01:00

admin commented

2026-01-23 11:35:02 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/KeyValueStore/pull/16
Author: @stanlemon
Created: 9/17/2013
Status: ✅ Merged
Merged: 9/17/2013
Merged by: @guilhermeblanco

Base: master ← Head: dbal-fix

📝 Commits (1)

2d01d5b Added missing use statement. Scrapped plain text query for query builder (the original one was missing a where clause too).

📊 Changes

1 file changed (+11 additions, -3 deletions)

View changed files

📝 lib/Doctrine/KeyValueStore/Storage/DBALStorage.php (+11 -3)

📄 Description

The current DBAL implementation does not appear to work. It is missing a use statement at the top for a DBAL Connection and the current query does not have a WHERE clause so it chokes. I switched this over to the query builder while I was fixing this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/KeyValueStore/pull/16 **Author:** [@stanlemon](https://github.com/stanlemon) **Created:** 9/17/2013 **Status:** ✅ Merged **Merged:** 9/17/2013 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `dbal-fix` --- ### 📝 Commits (1) - [`2d01d5b`](https://github.com/doctrine/KeyValueStore/commit/2d01d5b08ce0c6d417d7730e2fbbb4f023a36ce9) Added missing use statement. Scrapped plain text query for query builder (the original one was missing a where clause too). ### 📊 Changes **1 file changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/KeyValueStore/Storage/DBALStorage.php` (+11 -3) </details> ### 📄 Description The current DBAL implementation does not appear to work. It is missing a use statement at the top for a DBAL Connection and the current query does not have a WHERE clause so it chokes. I switched this over to the query builder while I was fixing this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-23 11:35:02 +01:00

admin closed this issue

2026-01-23 11:35:02 +01:00

admin referenced this issue

2026-01-23 11:35:07 +01:00

[PR #49] [MERGED] Implementation for Amazon DynamoDB #75

admin referenced this issue

2026-01-23 11:35:13 +01:00

[PR #79] [MERGED] Enhances existing dynamodb implementation and adds docs #104

Sign in to join this conversation.