[PR #96] [MERGED] DynamoDB internal refactoring #121

New Issue

admin · 2026-01-23T11:35:16+01:00

admin commented

2026-01-23 11:35:16 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/KeyValueStore/pull/96
Author: @EmanueleMinotto
Created: 10/20/2019
Status: ✅ Merged
Merged: 11/15/2019
Merged by: @EmanueleMinotto

Base: master ← Head: dynamodb-refactoring

📝 Commits (3)

1089486 DynamoDbStorage internal refactoring
9fe32a6 Add DynamoDB to documentation
76b76d4 Include DynamoDB tests on Travis

📊 Changes

6 files changed (+233 additions, -554 deletions)

View changed files

📝 .travis.yml (+2 -0)
📝 docs/reference/configuration.rst (+4 -11)
📝 lib/Doctrine/KeyValueStore/Storage/DynamoDbStorage.php (+69 -197)
📝 phpunit.xml.dist (+1 -0)
➕ tests/Doctrine/Tests/KeyValueStore/Storage/DynamoDbStorageTest.php (+157 -0)
➖ tests/Doctrine/Tests/KeyValueStore/Storage/DynamoDbTest.php (+0 -346)

📄 Description

Things done:

review documentation
replaced unitary test with functional test on Travis too
tables name and identifiers are extracted directly from DynamoDB

This closes https://github.com/doctrine/KeyValueStore/pull/89, closes https://github.com/doctrine/KeyValueStore/pull/88, closes https://github.com/doctrine/KeyValueStore/pull/87

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/KeyValueStore/pull/96 **Author:** [@EmanueleMinotto](https://github.com/EmanueleMinotto) **Created:** 10/20/2019 **Status:** ✅ Merged **Merged:** 11/15/2019 **Merged by:** [@EmanueleMinotto](https://github.com/EmanueleMinotto) **Base:** `master` ← **Head:** `dynamodb-refactoring` --- ### 📝 Commits (3) - [`1089486`](https://github.com/doctrine/KeyValueStore/commit/1089486506b76d7ed080380bfad1451628d323bb) DynamoDbStorage internal refactoring - [`9fe32a6`](https://github.com/doctrine/KeyValueStore/commit/9fe32a6388d23c2bf0f9a24398004655e6ca5241) Add DynamoDB to documentation - [`76b76d4`](https://github.com/doctrine/KeyValueStore/commit/76b76d42e99e8dd66e25c16d3d4e7ab5642b7028) Include DynamoDB tests on Travis ### 📊 Changes **6 files changed** (+233 additions, -554 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+2 -0) 📝 `docs/reference/configuration.rst` (+4 -11) 📝 `lib/Doctrine/KeyValueStore/Storage/DynamoDbStorage.php` (+69 -197) 📝 `phpunit.xml.dist` (+1 -0) ➕ `tests/Doctrine/Tests/KeyValueStore/Storage/DynamoDbStorageTest.php` (+157 -0) ➖ `tests/Doctrine/Tests/KeyValueStore/Storage/DynamoDbTest.php` (+0 -346) </details> ### 📄 Description Things done: 1. review documentation 2. replaced unitary test with functional test on Travis too 3. tables name and identifiers are extracted directly from DynamoDB This closes https://github.com/doctrine/KeyValueStore/pull/89, closes https://github.com/doctrine/KeyValueStore/pull/88, closes https://github.com/doctrine/KeyValueStore/pull/87 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-23 11:35:16 +01:00

admin closed this issue

2026-01-23 11:35:17 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/KeyValueStore#121