[PR #85] [CLOSED] Find all entities #110

New Issue

admin · 2026-01-23T11:35:14+01:00

admin commented

2026-01-23 11:35:14 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/KeyValueStore/pull/85
Author: @south634
Created: 5/30/2017
Status: ❌ Closed

Base: master ← Head: find-all-entities

📝 Commits (8)

4951789 Check for item after get attempt instead of before
869a8e3 Added test
1f34f52 Merge pull request #1 from ConsumerTrack/fix-fatal-error-on-missing-table-key
0174f75 Adding QueryBuilder support for dynamo
7e8dc70 Adding Orx, fixing parenthesis
97239b5 Adding support for embeddable entities
8624f2d Adding support for loading
9d37b8c Allow for find all Entities

📊 Changes

19 files changed (+1439 additions, -22 deletions)

View changed files

📝 lib/Doctrine/KeyValueStore/EntityManager.php (+15 -0)
📝 lib/Doctrine/KeyValueStore/Mapping/AnnotationDriver.php (+18 -3)
➕ lib/Doctrine/KeyValueStore/Mapping/Annotations/Embeddable.php (+29 -0)
➕ lib/Doctrine/KeyValueStore/Mapping/Annotations/Embedded.php (+33 -0)
📝 lib/Doctrine/KeyValueStore/Mapping/ClassMetadata.php (+3 -1)
📝 lib/Doctrine/KeyValueStore/Mapping/ClassMetadataFactory.php (+1 -1)
➕ lib/Doctrine/KeyValueStore/Query/Expr.php (+281 -0)
➕ lib/Doctrine/KeyValueStore/Query/Expr/Andx.php (+63 -0)
➕ lib/Doctrine/KeyValueStore/Query/Expr/Base.php (+124 -0)
➕ lib/Doctrine/KeyValueStore/Query/Expr/Comparison.php (+100 -0)
➕ lib/Doctrine/KeyValueStore/Query/Expr/Composite.php (+71 -0)
➕ lib/Doctrine/KeyValueStore/Query/Expr/Func.php (+78 -0)
➕ lib/Doctrine/KeyValueStore/Query/Expr/Orx.php (+63 -0)
➕ lib/Doctrine/KeyValueStore/Query/Parameter.php (+94 -0)
➕ lib/Doctrine/KeyValueStore/Query/QueryBuilder.php (+287 -0)
➕ lib/Doctrine/KeyValueStore/Query/QueryBuilderStorage.php (+41 -0)
📝 lib/Doctrine/KeyValueStore/Storage/DynamoDbStorage.php (+91 -3)
📝 lib/Doctrine/KeyValueStore/UnitOfWork.php (+44 -13)
📝 tests/Doctrine/Tests/KeyValueStore/Storage/DynamoDbTest.php (+3 -1)

📄 Description

Fixed issue of array being passed as $key to UnitOfWork::createEntity which caused UnitOfWork::tryGetById to error out
Set DynamoDbStorage::executeQueryBuilder to only add FilterExpression params to scan if expression exists

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/KeyValueStore/pull/85 **Author:** [@south634](https://github.com/south634) **Created:** 5/30/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `find-all-entities` --- ### 📝 Commits (8) - [`4951789`](https://github.com/doctrine/KeyValueStore/commit/4951789fd27e9707e0af4e173c741977b2ded48c) Check for item after get attempt instead of before - [`869a8e3`](https://github.com/doctrine/KeyValueStore/commit/869a8e395e9d2932036852ca04ec163145c531b8) Added test - [`1f34f52`](https://github.com/doctrine/KeyValueStore/commit/1f34f52eadf15b76dbc3d5a46b7d8ccd64906eab) Merge pull request #1 from ConsumerTrack/fix-fatal-error-on-missing-table-key - [`0174f75`](https://github.com/doctrine/KeyValueStore/commit/0174f7547b336b2f35bfad77a62734e20cec62da) Adding QueryBuilder support for dynamo - [`7e8dc70`](https://github.com/doctrine/KeyValueStore/commit/7e8dc70e48b550ea89958d4026adf301bf7f9027) Adding Orx, fixing parenthesis - [`97239b5`](https://github.com/doctrine/KeyValueStore/commit/97239b521c736565139d8d3effb0dcfb041f6e48) Adding support for embeddable entities - [`8624f2d`](https://github.com/doctrine/KeyValueStore/commit/8624f2d2a22d7aaf7cd413bb7e57ae9fa3128628) Adding support for loading - [`9d37b8c`](https://github.com/doctrine/KeyValueStore/commit/9d37b8ce2195ba43c18359ba9dedbe8c0c32aaf2) Allow for find all Entities ### 📊 Changes **19 files changed** (+1439 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/KeyValueStore/EntityManager.php` (+15 -0) 📝 `lib/Doctrine/KeyValueStore/Mapping/AnnotationDriver.php` (+18 -3) ➕ `lib/Doctrine/KeyValueStore/Mapping/Annotations/Embeddable.php` (+29 -0) ➕ `lib/Doctrine/KeyValueStore/Mapping/Annotations/Embedded.php` (+33 -0) 📝 `lib/Doctrine/KeyValueStore/Mapping/ClassMetadata.php` (+3 -1) 📝 `lib/Doctrine/KeyValueStore/Mapping/ClassMetadataFactory.php` (+1 -1) ➕ `lib/Doctrine/KeyValueStore/Query/Expr.php` (+281 -0) ➕ `lib/Doctrine/KeyValueStore/Query/Expr/Andx.php` (+63 -0) ➕ `lib/Doctrine/KeyValueStore/Query/Expr/Base.php` (+124 -0) ➕ `lib/Doctrine/KeyValueStore/Query/Expr/Comparison.php` (+100 -0) ➕ `lib/Doctrine/KeyValueStore/Query/Expr/Composite.php` (+71 -0) ➕ `lib/Doctrine/KeyValueStore/Query/Expr/Func.php` (+78 -0) ➕ `lib/Doctrine/KeyValueStore/Query/Expr/Orx.php` (+63 -0) ➕ `lib/Doctrine/KeyValueStore/Query/Parameter.php` (+94 -0) ➕ `lib/Doctrine/KeyValueStore/Query/QueryBuilder.php` (+287 -0) ➕ `lib/Doctrine/KeyValueStore/Query/QueryBuilderStorage.php` (+41 -0) 📝 `lib/Doctrine/KeyValueStore/Storage/DynamoDbStorage.php` (+91 -3) 📝 `lib/Doctrine/KeyValueStore/UnitOfWork.php` (+44 -13) 📝 `tests/Doctrine/Tests/KeyValueStore/Storage/DynamoDbTest.php` (+3 -1) </details> ### 📄 Description - Fixed issue of array being passed as $key to UnitOfWork::createEntity which caused UnitOfWork::tryGetById to error out - Set DynamoDbStorage::executeQueryBuilder to only add FilterExpression params to scan if expression exists --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-23 11:35:14 +01:00

admin closed this issue

2026-01-23 11:35:14 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/KeyValueStore#110