[PR #72] Fix DBALStorage to not ignore exceptions #105

New Issue

admin · 2026-01-23T11:35:13+01:00

admin commented

2026-01-23 11:35:13 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/KeyValueStore/pull/72
Author: @enumag
Created: 1/4/2016
Status: 🔄 Open

Base: master ← Head: patch-1

📝 Commits (1)

0eb1d88 Fix DBALStorage to not ignore exceptions

📊 Changes

1 file changed (+10 additions, -19 deletions)

View changed files

📝 lib/Doctrine/KeyValueStore/Storage/DBALStorage.php (+10 -19)

📄 Description

Is there some reason to catch all exceptions? If there is a problem with the storage I want to know about it, not silently ignore it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/KeyValueStore/pull/72 **Author:** [@enumag](https://github.com/enumag) **Created:** 1/4/2016 **Status:** 🔄 Open **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`0eb1d88`](https://github.com/doctrine/KeyValueStore/commit/0eb1d887ea39e534876332140a30a3710cfea8e0) Fix DBALStorage to not ignore exceptions ### 📊 Changes **1 file changed** (+10 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/KeyValueStore/Storage/DBALStorage.php` (+10 -19) </details> ### 📄 Description Is there some reason to catch all exceptions? If there is a problem with the storage I want to know about it, not silently ignore it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-23 11:35:13 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/KeyValueStore#105