[PR #19] [CLOSED] [WIP] Add logging and DataCollector #90

New Issue

2026-01-23T11:32:52+01:00

admin commented

2026-01-23 11:32:52 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/DoctrineCacheBundle/pull/19
Author: @dragonwize
Created: 4/25/2014
Status: ❌ Closed

Base: master ← Head: Add_logging_data_collector

📝 Commits (7)

7f161a4 Added foundation for logging and data collector.
2985cca Added ajax data dumper. Added logger tests. Updated profiler panel. Added doc blocks.
49e8b66 Fixed travis test issues.
2878f4e Fixed minor standards issues.
e3bc654 Merge branch 'master' into Add_logging_data_collector
3322379 Refactored logging to use service decorators. Misc PR cleanup.
ecdc680 Added parameters to control logging. Changed composer symfony min version. Renamed cache proxy.

📊 Changes

12 files changed (+760 additions, -1 deletions)

View changed files

➕ DataCollector/DoctrineCacheDataCollector.php (+62 -0)
📝 DependencyInjection/CacheProviderLoader.php (+31 -0)
➕ Logger/LogMaster.php (+112 -0)
➕ Logger/LoggingCache.php (+156 -0)
📝 Resources/config/services.xml (+7 -0)
➕ Resources/public/css/profiler.css (+13 -0)
➕ Resources/public/js/profiler.js (+36 -0)
➕ Resources/views/Profiler/dump.html.twig (+1 -0)
➕ Resources/views/Profiler/profiler.html.twig (+111 -0)
➕ Tests/Logger/CacheLoggerProxyTest.php (+84 -0)
➕ Tests/Logger/LogMasterTest.php (+146 -0)
📝 composer.json (+1 -1)

📄 Description

WORK IN PROGRESS

Architecture:

A service tag is added to provider services in the extension.
A compiler pass is used to replace the provider class with a proxy. For performance, this only happens if the kernel is in debug mode.
The proxies log certain calls and data to a central LogMaster.
The DataCollector uses the LogMaster to retrieve and display data in the debug toolbar and panel.
The LogMaster can be retrieved and used for any other purpose that needs access the logs.

To do:

Need a icon for the debug toolbar.
Finish profiler panel display
Doc blocks
Tests
General cleanup

... more

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/DoctrineCacheBundle/pull/19 **Author:** [@dragonwize](https://github.com/dragonwize) **Created:** 4/25/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `Add_logging_data_collector` --- ### 📝 Commits (7) - [`7f161a4`](https://github.com/doctrine/DoctrineCacheBundle/commit/7f161a46d65458de482a6829d48aca615beed106) Added foundation for logging and data collector. - [`2985cca`](https://github.com/doctrine/DoctrineCacheBundle/commit/2985cca1b0b25ad51ec3058de667b426bb69ad83) Added ajax data dumper. Added logger tests. Updated profiler panel. Added doc blocks. - [`49e8b66`](https://github.com/doctrine/DoctrineCacheBundle/commit/49e8b6688df696d6315b23b6ae068d22043046c8) Fixed travis test issues. - [`2878f4e`](https://github.com/doctrine/DoctrineCacheBundle/commit/2878f4e06752e232e036e10ac1b513b626b2aacf) Fixed minor standards issues. - [`e3bc654`](https://github.com/doctrine/DoctrineCacheBundle/commit/e3bc6541baf526ccb915a54d90b314501e8c0f81) Merge branch 'master' into Add_logging_data_collector - [`3322379`](https://github.com/doctrine/DoctrineCacheBundle/commit/3322379adaf52d8632dd2a5024f2b3a65e167e30) Refactored logging to use service decorators. Misc PR cleanup. - [`ecdc680`](https://github.com/doctrine/DoctrineCacheBundle/commit/ecdc6801f8547329dc3a8df7d5b026bd6d4ef366) Added parameters to control logging. Changed composer symfony min version. Renamed cache proxy. ### 📊 Changes **12 files changed** (+760 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `DataCollector/DoctrineCacheDataCollector.php` (+62 -0) 📝 `DependencyInjection/CacheProviderLoader.php` (+31 -0) ➕ `Logger/LogMaster.php` (+112 -0) ➕ `Logger/LoggingCache.php` (+156 -0) 📝 `Resources/config/services.xml` (+7 -0) ➕ `Resources/public/css/profiler.css` (+13 -0) ➕ `Resources/public/js/profiler.js` (+36 -0) ➕ `Resources/views/Profiler/dump.html.twig` (+1 -0) ➕ `Resources/views/Profiler/profiler.html.twig` (+111 -0) ➕ `Tests/Logger/CacheLoggerProxyTest.php` (+84 -0) ➕ `Tests/Logger/LogMasterTest.php` (+146 -0) 📝 `composer.json` (+1 -1) </details> ### 📄 Description WORK IN PROGRESS Architecture: - A service tag is added to provider services in the extension. - A compiler pass is used to replace the provider class with a proxy. For performance, this only happens if the kernel is in debug mode. - The proxies log certain calls and data to a central LogMaster. - The DataCollector uses the LogMaster to retrieve and display data in the debug toolbar and panel. - The LogMaster can be retrieved and used for any other purpose that needs access the logs. To do: - [ ] Need a icon for the debug toolbar. - [x] Finish profiler panel display - [x] Doc blocks - [ ] Tests - [x] General cleanup ... more --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-23 11:32:52 +01:00

admin referenced this issue

2026-01-23 11:33:02 +01:00

[PR #90] [MERGED] Link to the doc on symfony.com #143

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/DoctrineCacheBundle#90