[PR #26] [MERGED] Not modified content filter #33

Closed
opened 2026-01-23 11:23:03 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/code-rhapsodie/ezdataflow-bundle/pull/26
Author: @jeremycr
Created: 11/27/2019
Status: Merged
Merged: 10/23/2020
Merged by: @jeremycr

Base: masterHead: content_comparator


📝 Commits (1)

  • ad2a7eb Added content fields comparison to ignore updates that would result in no change

📊 Changes

21 files changed (+629 additions, -9 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 README.md (+78 -1)
📝 composer.json (+2 -1)
📝 phpunit.xml (+5 -5)
📝 src/CodeRhapsodieEzDataflowBundle.php (+3 -0)
src/Core/FieldComparator/AbstractFieldComparator.php (+32 -0)
src/Core/FieldComparator/DelegatorFieldComparator.php (+36 -0)
src/Core/FieldComparator/FieldComparatorInterface.php (+15 -0)
src/Core/FieldComparator/MapLocationFieldComparator.php (+18 -0)
src/Core/FieldComparator/MatrixFieldComparator.php (+29 -0)
src/Core/FieldComparator/NovaSEOMetasFieldComparator.php (+26 -0)
src/Core/FieldComparator/SimpleFieldComparator.php (+15 -0)
src/Core/FieldComparator/UrlFieldComparator.php (+15 -0)
src/DependencyInjection/Compiler/FieldComparatorCompilerPass.php (+35 -0)
src/Filter/NotModifiedContentFilter.php (+51 -0)
📝 src/Resources/config/services.yaml (+16 -0)
src/Resources/config/services/comparators.yaml (+42 -0)
📝 src/Writer/ContentWriter.php (+10 -2)
tests/Core/FieldComparator/DelegatorFieldComparatorTest.php (+49 -0)
tests/Filter/NotModifiedContentFilterTest.php (+138 -0)

...and 1 more files

📄 Description

  • Add tests
  • Supports some more field types
  • Handle language
  • Update README

Provides a filter (step) to exclude ContentUpdateStructure which fields are the same as the published version of the content.

Limitations:

  • Some native field types (like files) won't be supported as there is no way to actually compare values
  • For unsupported field types, values will be assumed different
  • As comparison generates some overhead, especially for contents with a lot of fields, do not use it if your data contains unsupported field types

Extensibility

Comparators for other field types can be added as tagged services.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/code-rhapsodie/ezdataflow-bundle/pull/26 **Author:** [@jeremycr](https://github.com/jeremycr) **Created:** 11/27/2019 **Status:** ✅ Merged **Merged:** 10/23/2020 **Merged by:** [@jeremycr](https://github.com/jeremycr) **Base:** `master` ← **Head:** `content_comparator` --- ### 📝 Commits (1) - [`ad2a7eb`](https://github.com/code-rhapsodie/ezdataflow-bundle/commit/ad2a7eb1fabc45e48800d4ab80bb03e3975ed5ca) Added content fields comparison to ignore updates that would result in no change ### 📊 Changes **21 files changed** (+629 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `README.md` (+78 -1) 📝 `composer.json` (+2 -1) 📝 `phpunit.xml` (+5 -5) 📝 `src/CodeRhapsodieEzDataflowBundle.php` (+3 -0) ➕ `src/Core/FieldComparator/AbstractFieldComparator.php` (+32 -0) ➕ `src/Core/FieldComparator/DelegatorFieldComparator.php` (+36 -0) ➕ `src/Core/FieldComparator/FieldComparatorInterface.php` (+15 -0) ➕ `src/Core/FieldComparator/MapLocationFieldComparator.php` (+18 -0) ➕ `src/Core/FieldComparator/MatrixFieldComparator.php` (+29 -0) ➕ `src/Core/FieldComparator/NovaSEOMetasFieldComparator.php` (+26 -0) ➕ `src/Core/FieldComparator/SimpleFieldComparator.php` (+15 -0) ➕ `src/Core/FieldComparator/UrlFieldComparator.php` (+15 -0) ➕ `src/DependencyInjection/Compiler/FieldComparatorCompilerPass.php` (+35 -0) ➕ `src/Filter/NotModifiedContentFilter.php` (+51 -0) 📝 `src/Resources/config/services.yaml` (+16 -0) ➕ `src/Resources/config/services/comparators.yaml` (+42 -0) 📝 `src/Writer/ContentWriter.php` (+10 -2) ➕ `tests/Core/FieldComparator/DelegatorFieldComparatorTest.php` (+49 -0) ➕ `tests/Filter/NotModifiedContentFilterTest.php` (+138 -0) _...and 1 more files_ </details> ### 📄 Description - [x] Add tests - [x] Supports some more field types - [x] Handle language - [x] Update README Provides a filter (step) to exclude `ContentUpdateStructure` which fields are the same as the published version of the content. ### Limitations: - Some native field types (like files) **won't be supported** as there is no way to actually compare values - For unsupported field types, values **will be assumed different** - As comparison generates some overhead, especially for contents with a lot of fields, **do not use it if your data contains unsupported field types** ### Extensibility Comparators for other field types can be added as tagged services. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-23 11:23:03 +01:00
admin closed this issue 2026-01-23 11:23:03 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: code-rhapsodie/ezdataflow-bundle#33