[PR #161] [MERGED] Switch variables from private to protected #300

New Issue

admin · 2026-01-24T11:37:22+01:00

admin commented

2026-01-24 11:37:22 +01:00

📋 Pull Request Information

Original PR: https://github.com/FriendsOfSymfony/FOSFacebookBundle/pull/161
Author: @tiois
Created: 7/10/2012
Status: ✅ Merged
Merged: 7/15/2012
Merged by: @stof

Base: 2.0 ← Head: 2.0

📝 Commits (1)

e5b85a0 Switch variables from private to protected

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 Facebook/FacebookSessionPersistence.php (+2 -2)

📄 Description

We can't extend this class because of those 2 private variables, it causes problem when calling properties on $session from the getPersistentData method.

It fails on this line because $session is not accessible.

if ($this->session->has($sessionVariableName)) {

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/FriendsOfSymfony/FOSFacebookBundle/pull/161 **Author:** [@tiois](https://github.com/tiois) **Created:** 7/10/2012 **Status:** ✅ Merged **Merged:** 7/15/2012 **Merged by:** [@stof](https://github.com/stof) **Base:** `2.0` ← **Head:** `2.0` --- ### 📝 Commits (1) - [`e5b85a0`](https://github.com/FriendsOfSymfony/FOSFacebookBundle/commit/e5b85a053ea2e8dca187cf1148a58a247ce21109) Switch variables from private to protected ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Facebook/FacebookSessionPersistence.php` (+2 -2) </details> ### 📄 Description We can't extend this class because of those 2 private variables, it causes problem when calling properties on $session from the getPersistentData method. It fails on this line because $session is not accessible. ``` php if ($this->session->has($sessionVariableName)) { ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-24 11:37:22 +01:00

admin referenced this issue

2026-01-24 11:37:40 +01:00

[PR #300] PR for fixing missing parameter fos_facebook.channel.expire with PHPUnit functional test #377

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FriendsOfSymfony/FOSFacebookBundle#300